Design comparison
SolutionDesign
Solution retrospective
feedback will be appreciated.
Community feedback
- @adarshcodesPosted over 4 years ago
Hi! @AsilTalyani, Let's see the different-different aspect of the solution:
- Design aspect: Design looks fine, but few things you can modify. The button should be side by side with the input box as shown in the design, on the smaller devices it would be fine.
There is a large space between the social icons, so just make
justify-content: center;
instead of space-between. And addmargin-right
to social icons. 1rem is looking fine to me, experiment with the value, and use what you like. - Responsive aspect: It works nicely until the breakpoint hit 415px, you can also decrease the width of input and button as the image. Issues aroused: Try to solve the accessibility and HMTL issues. Nice work👍 Happy Coding🙂
1@AsilTalyaniPosted over 4 years ago@adarshcodes Done updating code. Now it is working fine Thanks for your feedback
0 - Design aspect: Design looks fine, but few things you can modify. The button should be side by side with the input box as shown in the design, on the smaller devices it would be fine.
There is a large space between the social icons, so just make
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord