Mobile first, SCSS, BEM

Community feedback

• 

  Lucas Estevam•210

  @tl-lucasestevamPosted over 3 years ago

  First congratulations for submitting your first problem here from the front-end mentor!

  The first thing that should be mentioned is the use of divs around text, use semantic HTML tags (h1, h2, h3, he, h5, h6, p, etc), for example:

  <h1 class="card__title">
          Get <span>insights</span> that help your business grow.
  </h1>
  

  <p class="card__description">
          Discover the benefits of data analytics and make better decisions regarding revenue, customer experience, and overall efficiency.
  </p>
  

  <div class="card__achievement">
            <h5 class="card__stat">10k+</h5>
            <span class="card__stat-heading">
              companies
            </span>
  </div>
  

  Remembering that this is just an example, use the HTML tags that you think fit best.

  A problem I found was that you couldn't center the card, you can do it with flexbox as follows:

  body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  for the rest, it's a matter of you fixing the spacing and the color of the image overlay.

  If you have a specific question or with my bad English feel free to make comments here, keep studying and practicing!

  Marked as helpful

  2

  ---

  

  gearboz•360

  @kunsansangPosted over 3 years ago

  @tl-lucasestevam thank you a lot for fixing me, I've just adjusted some stuff for responsive also centering the card as you suggested, now I feel so damn good btw I couldn't find the right color for the overlay one so just made it up xD

  0