Mobile First, Sass (SCSS) + BEM, JavaScript and Flexbox + Grid

Community feedback

• 

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  Hello, I just did the same one today, really glad to see the same thing I did...

  One thing I would suggest is that there should be text align center on two headings...

  Hope it helps 😉

  1

  ---

  

  Guilherme Magno•300

  @devMagnoPosted over 3 years ago

  You're right! Thanks for pointing it out.

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Guilherme Magno! 👋

  It's great to see you back! 😀 Good work on this challenge! 👍 I think your solution looks great and is responsive! 🙌 I also like the smooth transition of the mobile navigation! 👏 The favicon you added is nice, too!

  I just noticed that the social media icons in the footer of the page aren't showing (their alt text or something is showing up instead). You might want to look into that and fix it! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  Thanks for your feedback, it is really good to be back! 😁

  The icons are showing up properly here but I'll take a look at it, thanks!

  1

  

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  I've made some small changes on those icons semantic using aria-label, is it working properly now?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @devMagno

  Perfect! 😀 The icons are working just fine, now! 👍

  1