[MOBILE FIRST / SASS] Accessible Responsive Contact Form

Community feedback

• 

  Krushna Sinnarkar•1,100

  @krushnasinnarkarPosted 4 months ago

  Hi @AReactDeveloper,

  Congratulations on successfully completing the challenge!

  Your current JavaScript code for form validation is functional, but there are some improvements you could make for better readability, maintainability, and efficiency. Here are a few suggestions:

  Key Improvements:

  1. Separate Concerns: Create separate functions for different types of validations.
  2. Reduce Repetition: Use a generic function for showing error messages.
  3. Consistent Naming: Maintain consistency in variable naming for clarity.
  4. Use forEach for Iteration: If validating multiple elements, consider using forEach.
  5. Improve isValid Handling: Ensure isValid is initialized to true and only set to false inside each validation function if any validation fails.

  Here's a revised version of your code:

  // Variables
  const form = document.getElementById('myForm');
  const firstName = document.getElementById('firstName');
  const lastName = document.getElementById('lastName');
  const email = document.getElementById('email');
  const general = document.getElementById('general');
  const support = document.getElementById('support');
  const message = document.getElementById('message');
  const consent = document.getElementById('consent');
  const submitMsg = document.querySelector('.succesMsg');
  
  const errorColor = 'hsl(0, 66%, 54%)';
  let isValid = true;
  
  const resetValidation = () => {
      isValid = true;
      document.querySelectorAll('.error').forEach(error => error.style.display = 'none');
      document.querySelectorAll('input, textarea').forEach(input => {
          input.style.borderColor = '';
          input.style.outlineColor = '';
      });
  };
  
  const showError = (input, message) => {
      input.style.borderColor = errorColor;
      input.style.outlineColor = errorColor;
      const errorElement = input.nextElementSibling;
      errorElement.textContent = message;
      errorElement.style.display = 'block';
      errorElement.style.color = errorColor;
      isValid = false;
  };
  
  const validateInput = (input) => {
      if (input.value.trim() === '') {
          showError(input, '*Input field required');
      }
  };
  
  const validateEmail = (input) => {
      const emailPattern = /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/;
      if (!emailPattern.test(input.value.trim())) {
          showError(input, '*Invalid email address');
      }
  };
  
  const validateRadio = () => {
      if (!general.checked && !support.checked) {
          const queryError = document.getElementById('queryError');
          queryError.style.display = 'block';
          queryError.style.color = errorColor;
          isValid = false;
      }
  };
  
  const validateConsent = (input) => {
      if (!input.checked) {
          const consentError = input.parentElement.nextElementSibling;
          consentError.style.display = 'block';
          consentError.style.color = errorColor;
          isValid = false;
      }
  };
  
  form.addEventListener('submit', (e) => {
      e.preventDefault();
      resetValidation();
  
      validateInput(firstName);
      validateInput(lastName);
      validateInput(message);
      validateEmail(email);
      validateRadio();
      validateConsent(consent);
  
      if (isValid) {
          submitMsg.style.display = 'block';
          setTimeout(() => {
              location.reload();
          }, 2500);
      }
  });
  

  Key Changes:

  1. Modular Functions: Validation logic is separated into individual functions.
  2. Centralized Error Handling: Error handling is managed by the showError function.
  3. Validation Reset: Added a resetValidation function to clear previous errors.
  4. Consistent Error Display: isValid is used consistently to track validation status.

  These adjustments should help make your code cleaner and more manageable.

  I hope you find this helpful.

  Feel free to reach out if you have more questions or need further assistance.

  Happy coding!

  1

  ---

  

  AReactDeveloper•340

  @AReactDeveloperPosted 4 months ago

  Thank you for your comment, @Krushnasinnarkar. I view functions as reusable blocks of code, and in my function to validate input, I reused the same line of code by placing it in a function for reuse throughout the code, which I found beneficial. I considered doing the same for validating email, radio buttons, and consent checkboxes, but it felt excessive to remove the code, rewrite it into a function, and then call it in the same place without reuse. While this approach may be worthwhile in a larger application, it seemed unnecessary for a small form.

  0