Mobile first responsive using CSS Grid and Flexbox

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi, code and outcome both look good on this

  Your stars look smaller than the design and have you just written in icons for those? That could cause rendering issues for some people, so it's considered best to use svgs in img tags or background images for these. Also they don't need to be in a paragraph tag. If you do them like this, they'd need to be in a span with an attribute of aria-hidden set to true.

  I hope that's helpful feedback ☺

  1

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted almost 4 years ago

  @grace-snow The stars should also be spaced some more. Plus the shade of color of the stars should be a little darker.

  0

  

  Yan•110

  @yannickhervePosted almost 4 years ago

  @grace-snow

  Hi thanks for your feedback this help is really helpful.

  0
• 

  Jane•1,040

  @janegcaPosted almost 4 years ago

  Hi Yan, your code is clear and easy to follow and the site looks good on different sized screens. One suggestion, the design calls for the paragraph text under the header to be hsl(301, 10%, 53%), not black.

  Nice job :)

  0