Mobile first responsive solution using Sass and flexbox

Community feedback

• 

  Saif Narpali•590

  @SaifN97Posted over 3 years ago

  Good job on the challenge 👏👏

  I am a big fan of sass too. They recently made a public notice on the deprecation of the @import rule, they are encouraging developers to use @use instead of @import.

  PS: with the @use rule, your CSS partials will be namespaced.

  Also I'll suggest looking more into the combo of using rem , em and % units instead of using px as it helps alot with the responsiveness.

  Lastly try to avoid setting fixed heights and use paddings and margins instead.

  Have fun coding! :)

  Marked as helpful

  0

  ---

  

  maheenriaz•10

  @maheenriazPosted over 3 years ago

  @SaifN97 sure, thankyou for your helpful advice!

  0
• 

  palharesmagnon•85

  @palharesmagnonPosted over 3 years ago

  Very nice work. Add a "role" property to your main div with the value equal "main" to solve this landmark accessibility issue

  Marked as helpful

  0

  ---

  

  maheenriaz•10

  @maheenriazPosted over 3 years ago

  @palharesmagnon sure

  0