@NehalSahu8055
Posted
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google. - It would be better if you use
<footer>
for your.attribution
class. - Try to add
accessibility features
like aria, sr-only, title.
I hope you find this helpful.
Happy coding๐
Marked as helpful
@abdullahmuslim
Posted
@NehalSahu8055
I'm aware of reponsive unit including vw, vh, vmin, ...
.
I used few like vw, vh and %
where I feel it's neccessary.
I'm really a noob, it will be more helpful if you can pin point areas where I should try those.
What more can I say, I'm grateful that you spend some of your time helping me out ๐
@NehalSahu8055
Posted
@abdullahmuslim
Have a look at this, it may help you a bit and try to explore more on youtube, google and blogs, practice will make you understand the differences.
@abdullahmuslim
Posted
@NehalSahu8055 Amazing article. The author's explanation are not very accurate i.e saying em is relative to the size of the parent element.