Skip to content
Submitted 6 months ago

Mobile First Responsive Four Card Design Using BEM

karthikganesanTR•130
@karthikganesanTR
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I continued to use BEM methodology and Mobile First in this project. I tried to use SASS in my next project and along with BEM and Mobile First approach.

I m exploring on Grid System.

What challenges did you encounter, and how did you overcome them?

I have trouble in placing the cards in correct position. I figured out way using grid-template-areas. we can always use other methods like grid-column and grid-row in child items to achieve that.

What specific areas of your project would you like help with?

NA

Community feedback

  • Grace•31,090
    @grace-snowPosted 6 months ago

    Really nice solution, well done!

    I only have a few suggestions.

    First, the header is a landmark with a banner role. It is meant to hold site-wide content like a logo or nav. It should never contain page specific content like headings because it is for repeating content across a whole site.

    Second is to make the card grid have its own container and stick to class names as selectors instead of using element selectors and nth child. Imagine this card grid as a component in a real site. If an author ever wanted to add another bit of content to the page. The styles would break because they're targeting direct children of the main landmark. It's also unnecessarily specific using direct child nth-child in the declarations.

    I hope that's helpful. These are more tips about overall architecture but it feels the right time for you to start considering this sort of stuff in the challenges.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord