Mobile-first QR code component (HTML & CSS)

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 3 months ago

  Hi, well done!

  A few suggestions:

  HTML:

  • The alt text should be written naturally, without using _ between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • There is no need to wrap the image in a <div>, so I would remove that.

  CSS:

  • I don't know how much normalize.css is used these days, but it's definitely best practice to include a CSS Reset at the beginning of the stylesheet.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • I would remove the positioning properties.

  • Remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also never be in px. You can use em, where 1em equals the element's font size.

  • You can remove font-weight: 400 from the body, as that is the default value.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  Marked as helpful

  1