Mobile first QR code component

Community feedback

• 

  Sylwia•240

  @LesSylPosted 3 months ago

  Hello, good work, but in my opinion it is better to stick to one unit length for example em. You use once px and another time rem in defining the margins. You can read more about this here: https://developer.mozilla.org/enUS/docs/Learn/CSS/Building_blocks/Values_and_units. Good luck.

  0

  ---

  

  Rivaldi Alfiansyah•90

  @CosaldiPosted 3 months ago

  @LesSyl ah i see, i forgot to convert it to rem.

  thank you for remind me, i will fix it later.

  0
• 

  Max Sakuma•30

  @msakuma-devPosted 3 months ago

  Wow. I learned so much just by looking how you code it! That's amazing! Thank you for putting the hard work and sharing your solution.

  0

  ---

  

  Rivaldi Alfiansyah•90

  @CosaldiPosted 3 months ago

  @msakuma-dev I'm glad to help you, thank you for your feedback.

  0