Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first QR code component

@Cosaldi

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

any feedback are welcome.

Community feedback

Sylwia 40

@LesSyl

Posted

Hello, good work, but in my opinion it is better to stick to one unit length for example em. You use once px and another time rem in defining the margins. You can read more about this here: https://developer.mozilla.org/enUS/docs/Learn/CSS/Building_blocks/Values_and_units. Good luck.

0

@Cosaldi

Posted

@LesSyl ah i see, i forgot to convert it to rem.

thank you for remind me, i will fix it later.

0

@msakuma-dev

Posted

Wow. I learned so much just by looking how you code it! That's amazing! Thank you for putting the hard work and sharing your solution.

0

@Cosaldi

Posted

@msakuma-dev I'm glad to help you, thank you for your feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord