Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first product card

P
Haydn Kerr• 535

@haydnkerr

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@themegazord

Posted

Hi Haydn Kerr, congratulations on the solution.

I have some scores to make for you to improve more and more.

1st Use classes and id in your HTML so that you can use them in CSS, this may not have been a problem, but imagine in a larger project, if you are guided only by HTML tags to assemble your CSS, you will become a monster kkkkk.

2nd In your CSS, it might be easier if you use :root and declare the color variables for your project, so instead of writing the hsl every time you tell the browser that it will be called for example --primary -white or the color you want.

Keep it up, you only tend to grow, congratulations.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord