Design comparison
Solution retrospective
I don't know whether using sections like this is right or wrong. I'd really appreciate feedback on that. Also added some effects to the sign up button. Hope everyone likes that. Also, any advise and feedback is appreciated.
Community feedback
- @grace-snowPosted about 3 years ago
Using sections does nothing at all semantically unless they include aria-labelledby pointing to the id of the heading within them. They are fine to have in there as they are on this, but it really makes no difference.
I recommend refactoring this to use css grid. That’s what the challenge is designed for and it’s an ideal practice ground
1@SJ-74Posted about 3 years ago@grace-snow Thanks for the feedback. So it's the same thing whether I used divs or section in my code? Unless and until aria-label was used?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord