@denielden
Posted
Hi Jill, great work on this challenge! 😉
Here are a few tips for improve your code:
- remove all unnecessary code, the less you write the better as well as being clearer: for example the comments
- to make it look as close to the design as possible reduce the size of eye image
- remove all
margin
from.card-container
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful
@jill-spencer
Posted
@denielden Thank you so much for your feedback- it was very helpful!