Mobile First Page with Flexbox, Grid, and Vanilla js
Design comparison
Solution retrospective
Hi I would love feedback on if my code is messy and any tips for improve writing clean code...
I also have a technical question regarding how to make the width of the underline that pops out when my mouse hovers over the menu links shorter?
Community feedback
- @aUnicornDevPosted over 3 years ago
You have
border-bottom
for the underline so it will take the complete width of the text. For variable widths, you can use::after
pseudo element.You can also change
.hamburger
position fromfixed
toabsolute
, because the fixed hamburger appears even after scroll.You should set a fixed max-width on the
.container
so that it does cover the whole screen on bigger viewports.Marked as helpful1@michellewongiPosted over 3 years ago@aUnicornDev Hi is there a recommended size to set the max-width to make the website responsive on larger viewports? If I set the .container of max-width: 1920px; for example, the whole website would be stuck at 1920px and if I move the screen size larger, there's just white space
0@aUnicornDevPosted over 3 years ago@mw3981 There won't be a problem if you have the CONTENT with white space around.
The navbar background, footer background, and the overall background won't be considered as the CONTENT
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord