MOBILE FIRST- Order Summary Component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Mohammad, good job! I took some time to look at your code and have some ideas for improving it:

  • remove margin from .container class because with flex they are superfluous
  • instead of using px try to use relative units of measurement -> read here
  • the best way for add the top image in the background is just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Mohammad Safwan•110

  @safXcodePosted over 2 years ago

  @denielden Noted, Thank you for the suggestion..

  1
• 

  Akhlak Hossain Jim•1,325

  @Akhlak-Hossain-JimPosted over 2 years ago

  Great work so far.

  Don't worry about accessing the figma file, I don't have it too. Hope these will solve some of your coding error:

  • <h4> Annual Plan</h4> try using h1 as first heading.
  • instead of <div class="container"> try using <main class="container">
  • wrap .attribution code block within footer tag
  • try not to keep alt="" empty in img tag

  Happy coding :)

  Marked as helpful

  1

  ---

  

  Mohammad Safwan•110

  @safXcodePosted over 2 years ago

  @Akhlak-Hossain-Jim thank you for looking at my code. fixed everything except heading, from now on words i will use h1 as my first heading

  0

  

  Akhlak Hossain Jim•1,325

  @Akhlak-Hossain-JimPosted over 2 years ago

  @safXcode always

  0