Mobile First - NFT Preview Card Component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Hélio, It looks good!...

  My suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  • I suggest you center the component on the page with Flexbox, by giving the parent element <main> the following properties:

  main {
     display: flex;
     justify-content: center;
     align-items: center;
     min-height: 100vh;
   }  
  

  Hope this is helpful to you... Keep coding👍

  Marked as helpful

  1

  ---

  

  Hélio Lúcio da Silva Júnior•270

  @helioLJPosted over 2 years ago

  @Bayoumi-dev Hey, thanks for the help, i will improve my code with your comment and i already pushed this into my repository :D

  0