Mobile first method + transitions + SASS

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @ricardodcc!

  Your solution looks excellent!

  I have a couple of suggestions:

  • First: Use <main> to wrap the main content instead of <main>, <div> and <article>.

  📌 The tag <div> has no semantic value.

  📌 The tag <article> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  • Second: Use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  Those changes have little or not effect at all on the project, but they make your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  1

  ---

  

  ricardodcc•110

  @ricardodccPosted 10 months ago

  Hi @danielmrz-dev! Thanks for your feedback. I used <main> > <div> ><article> to set max-width 1440px and 375px but looking back to the code i did not used the class .container.

  Also, i used the <article> tag because this card could perfectly be used in some random site and i could still understand his content because it is independent of the site context.

  Finnally, I used a <h2> because i was looking to this card in a big scenario, but i still think that in a bigger site I should have used a <h3> tag instead of <h2>.

  Other than that, thanks for all the suggestions that you gave!

  0