mobile first landing page with HTML SCSS JS and Tilt.js library

Community feedback

• 

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  Great work Vjekoni website is almost pixel-perfect, I have a couple of suggestions on your solution.

  I've noticed that for background images you were using over and over I would suggest using the class where you would define only once
  background-repeat: no-repeat; background-size: cover;

  Another thing is that for every background image you also create separate @media it would be much easier if all of those desktop images are under one @media query in my opinion

  I'm not familiar with the tilt.js library but for the card, with the title "Soccer team VR" looks like that tilt part of the script is not working. You might want to look into that.

  On mobile hamburger menu is not closing when you click any list item try using classList.toggle("show") on the link item.

  Keep on coding and improving!!

  0

  ---

  

  Vjekoslav•485

  @Vj3koPosted over 3 years ago

  @DEmanderbag tnx for feedback. I listened to your advice and made some changes. Added custom class for bg-repeat and bg-cover and also added one media query for all those images. On hamburger menu i added when the link is clicked, menu closes. Main section and creations section are now wrapped into main tag to make it clearer to see. ( this was suggested by mentor Grace ). I hope now it looks nicer and cleaner. Let me know if i can fix something else

  0