Mobile First Landing Page using SCSS and flexbox + grid

Community feedback

• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work! It would be great if you make hamburger menu in mobile view. And as @applepiegiraffe said, use only one <h1> tag on your page. I suggest you to study BEM naming convention. It's pretty cool. Happy coding~ :)

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Guilherme Magno! 👋

  Nice to see you complete another challenge! Good job on this one! 👍

  Your solution looks good and is responsive, and kudos for trying a mobile-first approach and adding hover states to all of the interactive elements of this challenge (many others often forget to add a hover state somewhere). 🙌

  I suggest,

  • Adding a little more padding around the sides of the page so there's just a wee bit more room between the content of the page and the edges of the screen when the screen width decreases in the desktop/tablet layout.
  • Taking a look at your solution report and trying to clear up a few of the errors that are there. As the report suggests, it is often considered a better practice to use a single <h1> tag on your page and use less important heading tags for the rest of the headings of the page. Also, don't forget to identify each <section> tag that you use with a heading to make your HTML more semantic!

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  Thanks for your feedback, I appreciate it!

  Maybe I should add invisible headings for each section? At least for those that don't have a heading like the quotes section or the benefits section?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @devMagno

  Yeah, I think you could do that! 👍

  0

  

  Guilherme Magno•300

  @devMagnoPosted almost 4 years ago

  Thanks bro!

  0