Mobile first landing page using SASS and BEM

Community feedback

• 

  Walter Sono•660

  @waltersonoPosted over 3 years ago

  Nice job domingoslatorre completing this challenge

  It looks very good, the mobile and desktop.

  You used the corrects HTML tags and even tried to support as much attributes for accessibility, very cool.

  Just as a suggestions:

  • Reduce the min-width

    • Because the mobile version start when there is still space for the design to be in desktop

  • Correct few things in BEM

    • page__social__item is good practice in BEM
    • A element can not have another element:
    • "An element is always part of a block, not another element. This means that element names can't define a hierarchy such as block__elem1__elem2." Quick start

  That is it, my fellow mentor.

  Maybe you could help each other with suggestions.

  Marked as helpful

  1

  ---

  

  Domingos Latorre•30

  @domingoslatorrePosted over 3 years ago

  @waltersono, thanks for the feedback.

  I tried to make the code as close as possible to the designs, using a fixed width for the page block. I'll try to keep this same approach and verify how the layout behaves at breakpoints between mobile and desktop (organic breakpoints for further refinement).

  Regarding BEM, I always think in terms of reusable blocks and sometimes I follow the hierarchy of html elements. Thanks for pointing.

  0