@vanzasetia
Posted
Hello, Rom! 👋
Congratulations on finishing this challenge! 🎉
Here are some suggestions for improvements.
- First, I would suggest writing your code in a consistent format. It will make it easier for you and other people to read your code. You can actually use a code-formatter like Prettier to format your code automatically.
- The download buttons should be links with
download
attribute. - There should not be text in
span
anddiv
alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element. - The
<div class="links">
should be a list that contains five bullet points. Also, if you think that it is a link then it should be wrapped by an anchor tag (not adiv
). The same goes for social media icons. - The page content that is wrapped by
aside
is not complementary content. It is the main content of the page. So, I suggest swapping theaside
withdiv
instead. - I would recommend setting the
body
font size withrem
unit. Setting thebody
font size to62.5%
and then usingem
to define the font size for the other elements can be tricky. It's becauseem
size will depend on the font size of the nearest parent element. It means that1em
can be different for each element. As a result, it will make it harder for you to debug the font size.
That's it! I hope this helps! 🙂
Marked as helpful
@RomWeb3
Posted
@vanzasetia Really helpful mate, thanks a lot !
@vanzasetia
Posted
@RomWeb3 Happy to hear that was helpful! 😊