Mobile first introductory section using CSS Grid and Flexbox

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hello

  Nice job on this :)

  A few suggested improvements

  • That logo is the most important info on the page but you're hiding it from search engines and assistive tech by leaving the alt text blank. Let them know the name of the site like everyone else
  • If only doing a 2 dimensional layout (main) it's more suited to flexbox than grid. Not essential either way.
  • Adding tabindex to images doesn't make them links. Wrap those images in anchor tags instead, and give them aria-labels so it's clear where they go to
  • Changing color on focus does not meet accessibility requirements. You need to add a distinct visible focus state on interactive elements
  • I recommend giving those social links a defined width and height so they stay circular. They are stretching/distorting at some screen sizes at the moment.

  I hope this helps you. Happy coding! :)

  0

  ---

  

  Jhoell Opeyemi•250

  @JhoellOpeyemiPosted over 3 years ago

  @grace-snow Thanks for the feedback :). Your feedback always helps me improve.. I'll correct the problems now

  0