Mobile first , Html,Scss

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. The layout both in desktop and mobile is good, and the responsiveness as well is great on this one.

  Some suggestions would be:

  • Avoid using height: 100vh a large container like the body tag. Using this makes the element only have the height of the viewport, the viewport is what you see on the screen. So meaning if you have a website that has many content and the height of course is large, the body will still have that 100vh or the 100% of the screen's height. Use min-height: 100vh on replace to the height. This will use 100% of the viewport's height, and it will expanded if it needs to. Remove the height.
  • Remove as well the width: 100vw on the body tag. This adds extra horizontal scrollbar. A block element does not need to their width to be set explicitly, since by default they will take 100% of the screens width.
  • The alt of the img could have been left empty alt="". If you think an image is just for decoration, it would be better to set the alt attribute empty. If the image adds any information, add a descriptive alt text.
  • The music icon as well could have used alt="".
  • The attribution is much better without the position: absolute and margin-top. Remove those 2 both, or just adjust the margin-top to a little unit like only 2 rem?

  Other than those, great job on this.

  Marked as helpful

  2
• 

  Ruben Abreu•70

  @RaCode75Posted about 3 years ago

  Thank you, very helpful!.

  0