Design comparison
Solution retrospective
Please Guys Give me feedback, how I can improve my code, and also let me know how to set the background images perfectly. Thanks
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi there, MOHD. AQUIB! 👋
Good work on this challenge! 👍 The card component looks pretty nice! 😀
The background images in this challenge can be a little tricky to place! I suggest playing around with viewport units and percentages to see if you can find a solution that keeps the background shapes more or less in their place when the page is resizes. That's what I did in my solution to this challenge, and it seemed to work out reasonably well. You can check my code out and play around with the
background-position
values in the dev tools, if you'd like any ideas. 🙂Besides that, you could perhaps use an
<article>
tag for the card component and make one of the elements (such as the name, maybe) inside it a heading to bump up the semantics of your HTML just a little.Hope that helps. 😉
Keep coding (and happy coding, too)! 😁
3
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord