mobile first html sass vanilla js

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Good job, again, Degoke! 🙌

  Like artimys said, keep it up! 👍

  😁

  1

  ---

  

  Degoke•210

  @DegokePosted about 4 years ago

  @ApplePieGiraffe thank you😊

  0
• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Looking good Degoke 👍👍 I think it's time for an advance challenge lol

  Some feedback:

  • The label tags probably don't need the for attributes since the input is inside the label

  • Might not matter actually but I'll throw it out there. When the error message appears it shifts the elements below a bit. Find a way to display the error message and have it not shift. Fixed height or invisibility: hidden instead of display: none. invisibility hidden hides it on the page but it still takes up the space as if it weren't hidden

  • Create a class that when applied to your form through JS, it activates the display: block and border-color

  Keep on going, you're doing great!!!

  1

  ---

  

  Degoke•210

  @DegokePosted about 4 years ago

  @artimys 🤗

  thank you for the suggestions

  0