Skip to content
Submitted over 3 years ago

Mobile first, HTML, css, flexbox, & BEM.

Raelinda•160
@Raelinda
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Clipboard landing page
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

This is my first time trying to code something that didn't fit neatly onto a single viewport. I can describe the experience in one word: humbling.

I would gratefully appreciate all feedback, but particularly organizational tips.

Community feedback

  • Raymart Pamplona•16,100
    @pikapikamartPosted over 3 years ago

    Hey, great work on this one. Layout for the desktop and mobile is really good and no issue when resizing it.

    Some suggestions would be:

    1. There is a scrollbar at the bottom which was caused by the min-width: 100vw on your header. Just omit/remote it to remove the scrollbar.

    2. Multiple usage of h1 tags. It may be debate on this, but it will be really if we just stick to one h1 per page. For other users, this may seem fine but for some, who uses screen readers, it might be an issue. It is more of accessibility.

    Just those two. But really, this is great and that custom property when an element is at focus, that is really good for navigation. Good job^^

    1
    Raelinda•160
    @RaelindaPosted over 3 years ago

    @pikamart Thanks so much! I’ll consider the h1 advice a best practice. :) — Raelinda

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord