Travolgi 🍕• 31,400
@denielden
Posted
Hey Chris, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- remove all unnecessary code, the less you write the better as well as being clearer: for example the
header
tag and thediv
containers of image - remove all
margin
fromcontainer, main and body
elements - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh and margin: 0
to body because Flexbox aligns child items to the size of the parent container - instead of using
px and %
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😁
Marked as helpful
0