Mobile first Flexbox CSS Grid

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, SAMIR HEMBROM! 👋

  Congrats on finishing another challenge! Your solution responds well and looks good. Here are few suggestions from me:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Wrap your socials icons into anchor elements <a> because they will redirect user somewhere.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  SAMIR HEMBROM•505

  @samirhembromPosted over 3 years ago

  Thanks @tediko for reviewing my challenge I will try to incorporate pseudo class focus from now onwards. Outline property is important for keyboard users point noted. I need to use anchor tag for the social icons another point taken.

  1

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @samirhembrom007 It doesn't necessarily have to be an outline property. You can use whatever styles you want. It is simply about making the element that has active focus on it more visible. Outline is most obvious one and often used.

  1