Skip to content
Submitted 4 months ago

Mobile first, Flex, BEM solution of Social links profile challenge

josip-h•90
@josip-h
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am the most proud of how much faster I finished this project than the previous one.

What challenges did you encounter, and how did you overcome them?

I have not encountered any challenges when solving this challenge.

What specific areas of your project would you like help with?

Any comments/suggestions are most welcome!

Community feedback

  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    Hi @josip-h,

    Congratulations on a great looking solution! You made some good progress. I like that you used CSS variables, have clear and concise class names and use semantic HTML tags. Good job!

    Some friendly constructive feedback:

    • You could try to put your links in a ul to make it a bit more semantically correct.

    I didn't notice anything else, you obviously have a good idea what you are doing!

    If you have any specific questions let me know.

    1
    josip-h•90
    @josip-hPosted 4 months ago

    Hi @DylandeBruijn,

    Thank you for your encouraging comments. I'm trying my best, and It's nice to hear such comments from someone at your level. I changed the div containing links to the unordered list as you recommended and nested links in the list items. Thanks again for your feedback. I'll have to read more on accessibility.

    0
  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    I'm glad I was able to help you out! Thank you for the kind words. Could you mark my comment as helpful when you have the chance? That would help me out a great deal!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord