Dylan de Bruijn• 3,190
@DylandeBruijn
Posted
Hi @josip-h,
Congratulations on a great looking solution! You made some good progress. I like that you used CSS variables, have clear and concise class names and use semantic HTML tags. Good job!
Some friendly constructive feedback:
- You could try to put your links in a
ulto make it a bit more semantically correct.
I didn't notice anything else, you obviously have a good idea what you are doing!
If you have any specific questions let me know.
1
Hi @DylandeBruijn,
Thank you for your encouraging comments. I'm trying my best, and It's nice to hear such comments from someone at your level. I changed the div containing links to the unordered list as you recommended and nested links in the list items. Thanks again for your feedback. I'll have to read more on accessibility.
0
