Mobile First FAQ Accordion CSS/JS/Flexbox
Design comparison
Solution retrospective
Please provide me some feedback, had too much difficulty dealing with flexbox, overflow and click based events on js. Any improvements? Flaws ? Or any practices I should follow?
It has been a month. Thank you.
Community feedback
- @ApplePieGiraffePosted about 4 years ago
Hey, Awais Muhammad Ahmed!
Good work! 👍
I suggest,
- I think allowing users to click on the title (rather than just the arrow) of each FAQ to open up that tab would be a good idea and make the accordion easier to use.
- Decreasing the space between the main title of the accordion and the image at the top of the accordion on the mobile layout would be nice, too.
Keep coding (and happy coding, too)! 😁
1@awaiskoraiPosted about 4 years ago@ApplePieGiraffe Understood I will correct those asap, however can you take a look at how I should deal with overflows here in .... it troubled me way too much. Thank you <3
0@ApplePieGiraffePosted about 4 years ago@awaiskorai
I think using absolute positioning to the place the cube was a good idea. You can use CSS background images to place the background image and use a negative value for its
position-x
property to place it partly off the accordion without having to worry about it overflowing its container (background images don't do that).As for the lady illustration, I think you just might have to set
overflow
tohidden
on the accordion for that, although you can use negative margins rather than relative positioning to place if off of the accordion, if you like.Happy coding! 😁
1@awaiskoraiPosted about 4 years ago@ApplePieGiraffe now that is some quality feedback. Loved it, el mentor <3 Thank you for dedicating the time.
0@ApplePieGiraffePosted about 4 years ago@awaiskorai
Glad to help!
Keep it up! 🙌
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord