Mobile first design with Sass

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, John! 👋

  Congrats on finishing another challenge. You're going like crazy 😅 I really like what you've done here. Here's my few suggestion:

  • Take a look at the moment when your site break to desktop (1000px width). Whole left site is cut. Try to fix that.
  • Change the alt attributes for the .profile images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a .stars. You can do it easily by using background-repeat approach in your css. Your approach is also good, I just give you an alternative.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  P

  John Norman•880

  @norman02Posted over 3 years ago

  @tediko Thanks for the great feedback!

  0