Mobile First design, Vanilla CSS & HTML5

Community feedback

• 

  Franziska Wich•210

  @franziskawichPosted over 3 years ago

  Hi, I'm a newbie as well. I think you included an incomplete fonts.google link in your head. The name and the stats should be bolder:

  link rel="preconnect" href="https://fonts.gstatic.com"

  link href="https://fonts.googleapis.com/css2?family=Kumbh+Sans:wght@400;700&display=swap" rel="stylesheet"

  The image of Victor is not centered quite right. It could move a few pixels up.

  Well done otherwise, looks pretty close to the design.

  0
• 

  jeepitou•35

  @jeepitouPosted over 3 years ago

  Hey, I'm also a newbie on this platform and took a look at your solution. I think your using first-child and nth-child way too much in your css. That must have been pretty hard to keep up with what your actually editing? first-child/nth-child is probably useful in some situation, but I think a class with a more descriptive name would have been better here.

  Other than that, result looks great!

  0

  ---

  

  George Al Ismail•200

  @maotao11Posted over 3 years ago

  Thanks for the feedback, i just realised im dumb and i could have done it the way you said :P

  0