Vanza Setia• 27,795
@vanzasetia
Posted
👋Hi RaffayElahi! My name is Vanza!
I have some feedback on this solution:
- Try to use other tags on your html such as
h2,ul,lirather than justdivandspan. - I see that you don't need two markup, one for mobile and the other for desktop. So, what you can do instead, you can just create the markup for the desktop and then just styling it differently base on different breakpoint.
- It's too early to apply mobile style,
flex-direction: column-reversefor the card on@media (max-width:1464px), it's still on desktop. - Try to refactor the code, which is try again from scratch, plan your markup and also your styling.
That's it! Hopefully this is helpful!
Happy Coding!
2
RaffayElahi• 130
@RaffayElahi
Posted
@vanzasetia Thanks Vanza! Loved your comment. Actually it was my first project and I didn't do much coding after that. However, I am back. Learning out creating process and improving it day by day. I would post more of solutions so I would love if you take a look at them and improve my coding process. Furthermore, I am gonna refactor it in few days. Thanks, Raffay Elahi
1
