Skip to content
Submitted over 2 years ago

Mobile first design done with SASS and Flex

Vasinc Daniel•190
@Vasinc
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Crowdfunding product page
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Any ideas on how I could improve my code and what I could've done would be so helpful. I would really appreciate if you'd take some of your precios time to review my work. Have a nice day ;)

Community feedback

  • Rio Cantre•9,690
    @RioCantrePosted over 2 years ago

    Hello there! Good job in completing this challenge. Regarding your solution, I would like you to notice the following…

    • The modal functionality is incomplete. The radio input is not working. The input for amount and button selection is missing
    • Add cursor: pointer for the bookmark and close-modal
    • You could create separate files for media queries, modal and variables for the styling

    Other than that...

    • Good job in using Sass for styling, the compositions are looking great
    • Proper usage of semantic tags
    • The HTML structure is well organized and readable
    • The design is well implemented with customized style
    • It's normal to have navigation bar for desktop but I think it's fine which you prefer
    • The project is responsive and used the details based on the original design
    • The modal is functional but incomplete features

    Above all, the project is done well. Keep up the good work! Cheers!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord