Submitted over 2 years ago

Mobile First CSS HTML JavaScript Advice Generator

Chris Mulvany• 120

@ChrisMulvanyGH

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Advice generator app

HTML
CSS
JS
API

2junior

View challenge

Design comparison

SolutionDesign

Community feedback

Will• 210

@wkan17012021

Posted over 2 years ago

Hi Chris,

This looks great, good effort. I noticed the top line "Advice", the designs say #117 as well. Not sure if this was left out intentionally. The pause button icon and horizontal line look as per the mobile design which is great. When the screen is increased to desktop size, I notice the horizontal line doesn't extend laterally all the way to the length of the quoted text above.

Other than that, it's top notch. Happy coding =)

Marked as helpful

Chris Mulvany• 120

@ChrisMulvanyGH

Posted over 2 years ago

@wkan17012021 Hi Will,

Thanks a million for your feedback and pointing out the mentioned issues. I really appreciate you taking the time out of your day to do that. I will make sure to address these issues and tag you in this thread when complete if that is OK with you.

Thanks again!

Chris

Chris Mulvany• 120

@ChrisMulvanyGH

Posted over 2 years ago

@wkan17012021

Hi Will

I made those changes you mentioned and would appreciate if you could cast and eye over it again. Along with some styling and html code clean up I also added a default JS function to load the advice slip id of 117. This then allowed me to have a default advice id and quote. Just to note advice id 117 is not the quote that came with the design files.

Thanks again!

Will• 210

@wkan17012021

Posted over 2 years ago

@ChrisMulvanyGH Hi Chris, I see what you mean now about the id number, thanks. The project you made is spot-on IMO. I don't have anymore suggestions, looks like you should be tackling more complex projects! 💪🏽

Hope you're enjoying the FEM challenges.

All the best, Will

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord