Mobile firsT, CSS Grid, Flex box and a little JS

Community feedback

• 

  Ksenia•1,350

  @kseniusPosted over 4 years ago

  My honest feedback, as you asked:

  First of all, you overuse buttons. You don't need to use the button tag for every element that resembles a button. Particularly in the landing page you've build I would use the button tag only in the subscription form in the footer. Secondly, I'd recommend you to learn more about flexbox, I've quickly looked through your style.css and it seems like you use it incorrectly (e.g. lines 476 and 490). I would also recommend to avoid deeply nested selectors.

  As for class names, you need to search for CSS naming conventions, choose one of them and stick to it. For example, there are BEM (Block, Element, Modifier), OOCSS (Object Oriented CSS, if I'm not mistaken) and some other CSS naming conventions of which I don't know much, but Google does :)

  2