@ApplePieGiraffe
Posted
Greetings, SnowFox! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉 Nice work on this one! 🙌 The different image that you added is a nice touch! 😀
One super tiny suggestion I have is to add a max-width to the card so that it isn't so wide when the layout first changes from desktop to mobile.
And I don't think you should use an <article>
tag for the container holding the image in the card component (since it isn't really a self-contained element that makes sense by itself). An <article>
tag for the entire card and <div>
s for the containers inside it might be a little better for semantics. Check out this thorough article from CSS Tricks to learn more about the <article>
and <section>
tags and their usage. 😉
Keep coding (and happy coding, too)! 😁
@ISnowFoxI
Posted
@ApplePieGiraffe Hi there and thank you.
I agree with you on that one, I'll set it to max-width:375px; so it stays the same for mobile view.
I tried to make the HTML more semantic but seems like I ended up using the wrong ones haha.
I will read the article you linked and also all make the changes as you suggested 😃.