Design comparison
SolutionDesign
Solution retrospective
How can i align profiles section better? I used flex-box and align-self property to align those items on different lines but doesn't work well.
Any corrections and better practices are also appreciated.
Community feedback
- @grace-snowPosted over 3 years ago
Hi
I'm viewing on mobile and on there and on the preview above all looks great!
Only suggested improvements to html are to
- remove the alt ratings. They can be empty alts, and I would add aria-hidden true on them as well to ensure apple voiceover doesn't announce them. The writing straight after them says "5 star" so you definitely don't want screenreaders to announce all those images.
- don't use the
<b>
tag, that's legacy and has no semantic meaning. Change font weight in css instead. Or when you want to add emphasis intentionally, use the string tag
Hope thats helpul
Marked as helpful1@chysomm62Posted over 3 years ago@grace-snow thanks a lot for the feedback, it's very helpful.
Please, if you don't mind, also check the desktop view. I think I am missing something in the alignment of the last cards. Thanks again.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord