@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
The repository is set to private or it doesn't exist.
-
For a photo of a person, use their name as the alt text.
-
The
altattribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.If you want to learn more about the
altattribute, you can read this article. 📘.
- While setting
height: 100%;is a common practice and even comes by default in some CSS resets, on smaller screens like mobile devices, the content can often exceed 100% of the screen. Consider usingmin-height: 100vh;instead for this type of components.
I hope you find it useful! 😄
Happy coding and Happy New Year! 🎉🎊🎁
Marked as helpful
@MusaddiqueAli
Posted
@MelvinAguilar Thanks Melvin, I followed all the suggestions you wrote in the previous comment. Thanks for reviewing my solution. By the way, I didn't know GitHub sets the repositories to Private. I thought it was always Public by default.
