Mobile first Base Apparel Page with TailwwindCSS

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these recommendation:

  				**HTML**
  

  ✅ Use HTML5 semantic elements. Make sure correct use of the HTML5 semantic elements like: header, footer, main, nav, article, section. It’s will help you to write more structured piece of code. But remember that they should be used only where necessary. In this case, this text is not very important, which implies a strong tag

  <strong class="font-light text-DesaturatedRed">We're</strong>
  

  ✅ Set a meaningful img alt attribute. It’s best practice for SEO purpose.

  <img src="./images/logo.svg" class="w-40 p-8 lg:w-40 lg:p-0" alt="" />
  
  

  ✅ Write Code Comments. It’s best practice to write human-readable code. Tried to comment your block of code. It will help you or any other developer to refactor the piece of code blocks. This is especially important when using the tailwind

  				**js**
  

  ✅ DONT repeat yourself. Try to use special functions

      emailNone.classList.remove("hidden");
      emailError.classList.add("hidden");
      emailSuccess.classList.add("hidden");
  
      inputBox.classList.remove("border-LightRed");
      inputBox.classList.add("border-Blue");
      document.emailForm.email.focus();
  
  
      emailNone.classList.add("hidden");
      emailSuccess.classList.add("hidden");
      emailError.classList.remove("hidden");
      inputBox.classList.remove("border-Blue");
      inputBox.classList.add("border-LightRed");
      document.emailForm.email.focus();
  

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0