P
Ian Parker• 180
@i-prkr
Posted
Great job on the solution, I enjoyed looking at it and liked how you've structured things! It made me consider improvements for my own solution.
I'm still learning and understanding best practices, but I found this article and used it to try to make the share icon links more accessible. You might find it helpful, I used the method of inserting an invisible screen reader only <span> with each link that can be read by screen readers for improved accessibility. (https://urm.wwu.edu/accessibility/guide/graphics-used-links-and-buttons-need-accessible-names.
Also I noticed that your font family doesn't have the 'sans-serif' modifier when declared, doing this should help to make the solution look a bit more like the design.
Nice work!!
0
