Mobile first approch using SCSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Greetings, Sandeep Gumaste! 👋

  Good effort on this challenge! 👍 Kudos for trying out Sass! 😀

  I suggest,

  • Adding cursor: pointer to the social media popup button.
  • Wrapping the social media icons in the popup in anchor tags (since they seem like links that will take the user somewhere when clicked).
  • Adding width: 100% to the card component and giving it a max-width (to prevent it from becoming too wide) instead of using width: 50% in the desktop layout (because it currently looks a bit squished in the desktop layout when the width of the screen decreases).
  • And if you don't want the colors of the social media popup button to be changed the desktop layout, you might want to check the width of the screen in your JS first (using window.innerWidth or something) and then decide to only add the class to the button that changes its colors if the width is above a certain value.

  Hope those tips help a little. 🙂

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  @ApplePieGiraffe Thankyou for the feedback!!

  1