Mobile First Approach Using SCSS and JS

Community feedback

• 

  Eric Salvi•1,350

  @ericsalviPosted over 3 years ago

  Hey looking good.

  I noticed that the desktop image gets squished when you resize the screen. It is usually best to set these types of images as background images and the size set to cover. That way it will fill in all available space and not look distorted on different screen sizes.

  You would then set the container that the background image is on as your exact measurements.

  If you didn't want to rebuild what you currently have, you could easily add object-fit: cover to the .hero__image .woman-desktop declaration in your CSS. But keep in mind IE doesn't support this. https://caniuse.com/?search=object-fit

  I am not seeing any type of validation on the email form when the user submits a valid email address.

  Also, double-check the report that gets generated when you submit the solutions. https://www.frontendmentor.io/solutions/mobile-first-approach-using-scss-and-js-mPIXywJXo/report These should be easy to fix.

  Other than those bits of feedback, you are doing a great job. This one in particular made me think and complete it over a few days. I needed to step away from time to time and clear my head. So kudos for completing it!

  2

  ---

  

  Arda•85

  @ardaberrunPosted over 3 years ago

  @ericsalvi Thank you for your feedback. I am appreciate :)

  0