Mobile first approach using flexbox

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Hi, nice work. As a first work this is really nice. There are few problems but it's ok for first attempt. I am confused about your breakpoint max-width: 1000px. Please check standard breakpoints value.

  Happy coding

  Marked as helpful

  1
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi!

  I have some feedback on this solution:

  • You should use min-height instead of height on your container. On mobile view the card gets cut off.
  • You should only have one h1 for every page, also the sts should be p element too not a heading. Use heading tags as a title of every section.
  • In this case, you can leave the alt="" empty, since it's just a decorative image.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1