Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first approach created Recipe-Page

@begli-amanov

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

  • With the next project I will try to identify all similarities and differences between the elements and try to style them in a single rule, where possible. It could reduce the amount of editing of css file in a long way. After I've made my last commit, I've deleted another 25-30 unused lines of code.

What challenges did you encounter, and how did you overcome them?

There was different challenges I've encountered and all of them was funny to overcome. For example:

  • Creating borders for the table without setting its border-collapse set to collapse property. It does not work then.

  • When I used line-indent on the list-item text within this item is getting moved to the given direction, however the next line of the text starts a bit left from the first line. I've tried several properties, but the only way I've achieved desired results was setting padding-left: 1rem on element. Jap, so easy.

  • On the desktop and mobile version the image is looks differently. Mobile uses the full width of the page, where desktop version encloses it within a parent element and applies border-radius on it and so on. Solution I've used here is two different images with display properties set to hidden when needs one, and revealing it when it needs.

Overall it was very interesting challenge to overcome

What specific areas of your project would you like help with?

Always excited about writing semantic HTML and CSS classes naming conventions. I will welcome any feedback regarding these.

Community feedback

P
lynx232 110

@lynx232

Posted

"Does the solution include semantic HTML?" It does. But I would suggest to avoid empty tags such as <div> as much as possible in the future as they don't leave much room for interpretation for screen readers.

"Is it accessible, and what improvements could be made?" It is.

"Does the layout look good on a range of screen sizes?" Excluding ultrawide monitors(where the card stretches out width wise) it does.

"Is the code well-structured, readable, and reusable?" Yes. Good use of comments for categorizing in the css file.

"Does the solution differ considerably from the design?" Nope. Almost spot on... Good job!

Marked as helpful

1

@begli-amanov

Posted

@lynx232, very much appreciate your words!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord