Skip to content
Submitted over 3 years ago

Mobile first and flexbox with css and javascript vanilla

GoakingFy•50
@GoakingFy
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Rock, Paper, Scissors game
  • HTML
  • CSS
  • JS
4advanced

Design comparison

SolutionDesign

Solution retrospective

Hello, this is my first fronted challenge, I have started with an advanced one, although I do not have enough knowledge to create this challenge in a more orderly and clean way, I know it is not the best way to do it but I could not think of any other way vanilla form. Advice to improve, both in methodology and logic, would be appreciated, thanks

Community feedback

  • Grzegorz Sterczewski•680
    @gsterczewskiPosted over 3 years ago

    Hello GoakingFy 👋, my name is Grzegorz.

    Here's my suggestions, I hope they will be useful to you

    Your first try is nice, but there is a room for improvements.

    • I think you should use button element instead of div for hand,paper,scissors. That would give you a lot of accessibillity out of the box.

    • Consider adding button to close rules modal, since now it's not very accessible.

    I have some other tips, nut for now let's focus on improving those 'low hanging fruits'.

    Keep up the good work! 💪

    See you on the coding trail 😉

    Cheers!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord