@rayaatta
Posted
Hello Enoch👋, congratulations on completing your first FED challenge 🎉
I have some suggestions you might find useful.
1
Every html document must have a main tag that encloses the main page content.
Change
<div class="hero">
to
<main class="hero">
using semantic markup improves SEO* and user experience for people using assistive technology like screen readers.
You can learn more about the main tag in this article📰.
2
Change height: 100%; on the body and html to
min-height:100%;
This makes sure that content does not overflow on short devices or mobile devices in landscape mode.
I hope this helps 🙃
Happy coding ✌️
Marked as helpful
@djamkenny
Posted
@rayaatta Thanks so much for taking the time to comment on my solution. I have will do that since it is the best practice...thanks so much
