Community feedback

• 

  William Nicholson•75

  @Passenger89Posted over 3 years ago

  Hey, just took a look at your solution on github pages. Looks great. Very accurate and responsive! Keep it up!

  edit: Just a minor point i'd like to make. I noticed that you have used <a> tags for your buttons. If you wish to improve accessibility then you could check out this link:

  https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role

  After clicking the link, check out the section under "Accessibility concerns" and "Best practices".

  1

  ---

  

  Rohit Kumar•125

  @rohits673Posted over 3 years ago

  @Passenger89 Hi, Thanks for sharing this important information. I will try to implement it in my projects. Here for all the buttons I have used anchor tags not the button element because they wouldn't trigger an action, they would almost certainly trigger navigation to a page or section about that car.

  1