Design comparison
Solution retrospective
Hello everyone
I tried to update the solution according to the feedback from the community, hope that it is better now :)
Community feedback
- @NaveenGumastePosted over 2 years ago
Hello Iva ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
- Always use
h1
first and thenh2
,h3
and so on
happy Coding😀
Marked as helpful1 - Always use
- @PhoenixDev22Posted over 2 years ago
Hello Iva ,
Congratulation on completing another challenge of frontend mentor ,
I have some suggestions regarding your solution:
- Page should contain a level-one heading . As this is not a real webpage , you can use
<h1>
withclass="sr-only"
(Hidden visually, but present for assistive tech)
And it is essential that interactive elements have
focus-visible
styles as well as hover styles. These need to be really clear and obvious as they are needed to help a keyboard user know where is focused on the page.border-radius
andoverflow hidden
to the main container that wraps the three cards so you don't have to set it to individual corners.
Overall, your solution is great , Hopefully this feedback helps.
Marked as helpful1 - Page should contain a level-one heading . As this is not a real webpage , you can use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord