Design comparison
SolutionDesign
Community feedback
- @Ridwan10000Posted 4 months ago
@Ricardo-Barbosantos congratulations on completing on your first project. You have done a great job. Just a few remarks. You are missing
<main>
land mark. Also you don't need to add media queries. Just addmax-width
property in yourcontainer
rule. Usemin-height:100vh
instead of justheight:100vh
in the body rule. Also you want to add the attributions in<footer>
element.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord